node: fix the rest of test-process #16026
Open
+2,833
−834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 9:12 PM PT - Jan 3rd, 2025
❌ @nektro, your commit 83ce207 has 2 failures in
🧪 try this PR locally: bunx bun-pr 16026 |
Jarred-Sumner
requested changes
Jan 3, 2025
Jarred-Sumner
requested changes
Jan 4, 2025
There was a problem hiding this comment.
We shouldn't make error: print as Error:
- There are very likely 3rd-party scripts depending on this behavior
- It's aesthetically worse
We can make whatever tests that specifically check for the string "Error:" instead check for "error:", or we can make sure it's using util.inspect isntead of Bun.inspect / console.log in the appropriate places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supercedes #14621
fixes all the tests that don't depend on missing behavior in
node:child_processornode:v8a few missing for
process.envthat will get a separate followupnot done, pushing now so the robobun comment is at the top